Replace Jest with Vitest 2 #4728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
===========================================
- Coverage 90.48% 71.14% -19.34%
===========================================
Files 265 262 -3
Lines 38113 37819 -294
Branches 3166 1955 -1211
===========================================
- Hits 34488 26908 -7580
- Misses 2650 9638 +6988
- Partials 975 1273 +298 ☔ View full report in Codecov by Sentry. |
birkskyum
force-pushed
the
vitest-2.0
branch
2 times, most recently
from
4762bb5
to
9386082
Compare
This was referenced Sep 21, 2024
birkskyum
force-pushed
the
vitest-2.0
branch
from
1c217a6
to
191982c
Compare
birkskyum
force-pushed
the
vitest-2.0
branch
3 times, most recently
from
9f50b69
to
47ea443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the test runner (unit/integration/build) from Jest to Vitest 2, which has built-in support for TS/ESM and the same syntax as Jest. This PR serves to help us evaluate the option, and to move forward faster if there's a decision to proceed at some point.
A key motivation for examining this change is that I've found it quite challenging to move these tickets forward:
Part of the struggle is that Jest only has experimental ESM support, and I've so far not managed to see an effect of the useESM setting in the ts-jest plugin used in this repo.
It's a continuation of
Relates to Rolldown, because vitest is downstream of vite, and thus eventually will swap internals to use rolldown:
Relates to browser runner, because vitest is working on a browser mode:
Launch Checklist